Re: cvs: php-src /ext/reflection php_reflection.c

Hello Johannes, iirc this is based on fixing a bug, thus came in later. marcus Friday, August 17, 2007, 4:21:01 PM, you wrote: > johannes Fri Aug 17 14:21:01 2007 UTC > Modified files: > /php-src/ext/reflection php_reflection.c > Log: > - Mark the parameter for ReflectionProperty::GetValue as optional > # [DOC] The documentation on this is wrong, too. The parameter is only > # needed for getting the value of an object's property, not for static > # ones. (I'm not sure if it has always been that way...) > > > > http://cvs.php.net/viewvc.cgi/php-src/ext/reflection/php_reflection.c?r1=1.280&r2=1.281&diff_format=u > Index: php-src/ext/reflection/php_reflection.c > diff -u php-src/ext/reflection/php_reflection.c:1.280 > php-src/ext/reflection/php_reflection.c:1.281 > --- php-src/ext/reflection/php_reflection.c:1.280 Tue Jul 24 23:16:47 2007 > +++ php-src/ext/reflection/php_reflection.c Fri Aug 17 14:21:00 2007 > @@ -20,7 +20,7 @@ > +----------------------------------------------------------------------+ > */ > > -/* $Id: php_reflection.c,v 1.280 2007/07/24 23:16:47 johannes Exp $ */ > +/* $Id: php_reflection.c,v 1.281 2007/08/17 14:21:00 johannes Exp $ */ > > #ifdef HAVE_CONFIG_H > #include "config.h" > @@ -4817,7 +4817,7 @@ > ZEND_END_ARG_INFO() > > static > -ZEND_BEGIN_ARG_INFO(arginfo_reflection_property_getValue, 0) > +ZEND_BEGIN_ARG_INFO_EX(arginfo_reflection_property_getValue, 0, 0, 0) > ZEND_ARG_INFO(0, object) > ZEND_END_ARG_INFO() > > @@ -5022,7 +5022,7 @@ > php_info_print_table_start(); > php_info_print_table_header(2, "Reflection", "enabled"); > > - php_info_print_table_row(2, "Version", "$Id: php_reflection.c,v > 1.280 2007/07/24 23:16:47 johannes Exp $"); > + php_info_print_table_row(2, "Version", "$Id: php_reflection.c,v > 1.281 2007/08/17 14:21:00 johannes Exp $"); > > php_info_print_table_end(); > } /* }}} */ Best regards, Marcus