Re: [PATCH] Restructuring built-in variables

On Sun, Apr 13, 2008 at 3:16 AM, Daniel Convissor <danielc@analysisandsolutions.com> wrote: > Hi Hannes: > > Overall, seems like a good idea. > > > > Index: en/language/predefined/variables/argc.xml > > + The scripts filename is always passed as an argument to the script > ... > > Index: en/language/predefined/variables/argv.xml > > + The first argument is always the current scripts filename. > > Please add the apostrophes: script's Fixed. > > Index: en/language/predefined/variables/cookie.xml > > Here, and with other similar variables, perhaps it would be good to > include a statement saying that the old variables (eg $HTTP_COOKIE_VARS) > are deprecated. The idea is to first refactor it with minimum changes so translators don't have to retranslate the entire thing again. Then after the commit it is easy to make any further adjustments, but yeah. That should be noted. > > + An associative array of variables passed to the current script > > + via HTTP Cookies. Automatically global in any scope. > > That last sentence seems supurfluous considering "&note.is-superglobal;" > is on the page. This same concept applies to most, if not all, of these > pages. Fixed. > > > > Index: en/language/predefined/variables/globals.xml > > + &reftitle.changelog; > > + <entry>Enter the version of change here</entry> > > + <entry> > > + Describe the change > > Uhhhh... :) Nice catch, fixed. -Hannes