Re: cvs: php-src(PHP_5_3) / NEWS /ext/sockets php_sockets.h sockets.c

Hi 2009/1/1 Pierre Joye <pierre.php@gmail.com>: > hi! > > On Thu, Jan 1, 2009 at 7:31 PM, Kalle Sommer Nielsen <kalle@php.net> wrote: > >> Because of stream_socket_pair(), and then it would only work if >> ext/sockets was built too, so unless we move it into the core and >> export it then it should be like that. > > Does it even work? I would not enable again this function without > first having tests for it. There is certainly reasons why it was > disabled (well, ext/socket is a reason already...). Like I just said on IRC, it was Jani that added a magic define back around the time 5.1 was released, which Windows didn't have and it was disabled: http://cvs.php.net/viewvc.cgi/php-src/ext/sockets/sockets.c?r1=1.190&r2=1.191 > > Cheers, > -- > Pierre > > http://blog.thepimp.net | > http://www.libgd.org > -- Kalle Sommer Nielsen