Re: Hello phpdoc people and SPL ArrayObject patch
| From: | Philip Olson | Date: | Thu, 02 Jul 2009 16:36:02 +0000 |
| Subject: | Re: Hello phpdoc people and SPL ArrayObject patch | ||
| References: | 1 2 3 4 5 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969380555@lists.php.net to get a copy of this message | ||
On Jul 2, 2009, at 4:06 AM, Joris van de Sande wrote:
On Wed, Jul 1, 2009 at 3:40 PM, Kalle Sommer Nielsen<kalle@php.net> wrote: Hi Kalle,Hello Joris, You've done plenty of good work, so please apply for a CVS account so that you may start committing yourself. - http://php.net/cvs-php One note, please use <methodname> more. So: Good: <methodname>RecursiveArrayIterator::getChildren</methodname> Bad: <link linkend="recursivearrayiterator.getchildren">RecursiveArrayIterator::getChildren</link> The build system will take care of the links. The same applies for <classname> and many others. Regards, PhilipJuliette have just committed those docs without me knowing: http://news.php.net/php.doc.cvs/4304The constants are not documented yet, so I have added documentation for the constants. The patch can be found at: http://www.devplace.nl/phpdoc/phpdoc.spl.arrayobject.20090702.diffSo instead, you should document another class thats not documented within SPL instead, send it for review and then commit it. To generate a list of missing SPL docs, then have a look at the php script in "phpdoc/scripts/check-missing-spldocs.php". If you have any questions regrading this, feel free to email us back.I have documented the RecursiveArrayIterator class (which was a very small one to document). This patch can be found at: http://www.devplace.nl/phpdoc/phpdoc.spl.recursivearrayiterator.20090702.diff I can understand if that's not enough to gain CVS write access. In the near future I am going to document some more SPL classes :) .