Re: svn: /phpdoc/en/trunk/reference/datetime/ timezones.xml

2009/7/30 Hannes Magnusson <hannes.magnusson@gmail.com>: > On Thu, Jul 30, 2009 at 12:59, Hannes > Magnusson<hannes.magnusson@gmail.com> wrote: >> On Thu, Jul 30, 2009 at 12:56, Richard Quadling<rquadling@php.net> wrote: >>> rquadling                                Thu, 30 Jul 2009 10:56:29 >>> +0000 >>> >>> Revision: >>> http://svn.php.net/viewvc?view=revision&revision=286550 >>> >>> Log: >>> TimezoneDB updated to version 2009.11 (2009k) >>> >>> Changed paths: >>>    U   phpdoc/en/trunk/reference/datetime/timezones.xml >>> >>> Modified: phpdoc/en/trunk/reference/datetime/timezones.xml >>> =================================================================== >>> --- phpdoc/en/trunk/reference/datetime/timezones.xml    2009-07-30 10:53:04 UTC (rev >>> 286549) >>> +++ phpdoc/en/trunk/reference/datetime/timezones.xml    2009-07-30 10:56:29 UTC (rev >>> 286550) >>> @@ -8,7 +8,7 @@ >>> >>>  <note> >>>   <simpara> >>> -   This list is based upon Version 2009.10 of the timezonedb. >>> +   This list is based upon Version 2009.11 of the timezonedb. >>>   </simpara> >>>  </note> >> >> That page is generated, right? > > Errr.. And because this is generated page no english text should be > there. It should be an entity so translations can have it in correct > language. > > > -Hannes > > -- > PHP Documentation Commits Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > I rundoc-base/scripts/gen-phpdoc-tz-list.php and diff to the current en/reference/datetime/timezones.xml. I commit if different. Taking on board the issue about the English text, this would be easier if .... <simpara> This list is based upon the timezone db Version 2009.10. </simpara> So, becoming <simpara> &date.timezone.dbversion; <?php echo timezone_version_get(); ?>. </simpara> with a new entity of <!ENTITY date.timezone.dbversion 'This list is based upon the timezone db Version'> Testing (not added an entity before, so testing ...) -- ----- Richard Quadling Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731 "Standing on the shoulders of some very clever giants!" ZOPA : http://uk.zopa.com/member/RQuadling