Re: Commit document
| From: | Christopher Jones | Date: | Fri, 23 Apr 2010 17:56:40 +0000 |
| Subject: | Re: Commit document | ||
| References: | 1 2 3 4 5 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969381717@lists.php.net to get a copy of this message | ||
Yannick Torrès wrote:
Is it really necessary to allow valid user to save as a patch ? Perhaps we can just allow "save as a patch" for anonymous user.Some unification & simplification of processes and terminology would really help. The difference between "Pending for commit" and "Pending patches" isn't obvious. I think the process should only distinguish between "work in progress" and "complete work". In the UI I'd label them "Incomplete patches" and "Completed patches". Anonymous users should be allowed (somehow) to "Save" files so they are in the "Incomplete patches" queue, just the same as an authenticated user. There should one button (Save), not two (Save & Save as patch). There should be a way to change the patch state from Incomplete to Complete when the author is happy with the content alteration. In the "Completed patches" queue it should be straightforward for authenticated users to commit. Completed patches by Anonymous users could also go into the "Completed patches" queue, or to a separate "Contributed Patches" queue. Chris -- Email: christopher.jones@oracle.com Tel: +1 650 506 8630 Blog: http://blogs.oracle.com/opal/ Free PHP Book: http://tinyurl.com/ugpomhome