Re: Contributions are ready for review

Hi Peter, 2011/1/10 Peter Cowburn <petercowburn@gmail.com>: > On 10 January 2011 13:00,  <phpdoc@lists.php.net> wrote: >> >> Hello PHP EN Documentation team, >> >> There are contributions within the online editor queue for this language.. >> Please review, then commit or delete these patches. > > For the "Patches for review" section, is there any way for us to apply > them? In the editor, I can see the diffs/changes for joey and conf's > patches but not commit them.  When opening the changed files in the > editor, I cannot save them as my own work in progress (to then > commit). In this module, when a file have been modified by a valid VCS user, you can just review it, but can't commit it. Karma is checked at logging time, so this vcs user can commit it his self. Anyway, if a valid user have modified a file a long time ago, without commit it, a global or lang admin can modify the owner of this file. As it, the new owner can commit the change, or just clear it. For anonymous user modification, I plan to modify it quickly. Actually, you must open the modified file as a valid user, and the editor tell you that you can modify it. Just modify the file to became the new owner of this file, and then, commit it or not. > > As for the "Work in progress" section, I cannot see any of them in the > editor... maybe it is intentional, but if so then why list them here? I have seen some bad entries in the mail, yes. By bad entries, I just mean that there is a mistake in the DB and I must change it and investigate how this user was able to do that. Best, Yannick > > (If it makes a difference, I logged in for the English language as a > VCS user, not anonymous.) > >> >>    Work in progress : >>    ----------------------- >>        * (new) On 2010-05-24 16:36:37 by markskilbeck : en/reference/cairoimages/- >>        * (new) On 2010-08-03 11:57:22 by mfonda : >> en/reference/array/functions/key-exists.xml >>        * (new) On 2010-08-10 04:48:00 by dragoonis : >> en/reference/network/functions/http-response-code- >>        * (new) On 2010-08-10 05:32:52 by dragoonis : >> en/reference/network/functions/http-response-code/ >>        * (new) On 2010-09-11 05:30:24 by anonymous #476 : en/referencessdeep/- >>        * (new) On 2010-09-12 15:15:46 by anonymous #478 : en/chapters1/- >>        * (update) On 2010-07-23 23:24:22 by anonymous #249 : >> en/reference/mysqli/mysqli/real-connect.xml >>        * (update) On 2010-08-03 11:58:40 by mfonda : >> en/reference/array/entities.functions.xml >>        * (update) On 2010-09-13 17:18:18 by danbrown : en/reference/sdo/setup.xml >>        * (update) On 2010-09-26 07:22:48 by anonymous #532 : >> en/reference/fileinfo/functions/mime-content-type.xml >>        * (update) On 2010-09-29 09:19:34 by anonymous #539 : >> en/features/commandline.xml >>        * (update) On 2010-10-08 13:27:08 by anonymous #569 : >> en/reference/stream/streamwrapper/stream-open.xml >>        * (update) On 2010-10-10 13:35:59 by anonymous #478 : >> en/reference/amqp/amqpconnection.xml >>        * (update) On 2010-10-12 01:36:47 by anonymous #283 : en/extensions.ent >>        * (update) On 2010-10-26 04:56:37 by anonymous #619 : >> en/reference/filesystem/functions/fnmatch.xml >>        * (update) On 2010-12-06 17:11:48 by anonymous #808 : en/faq/com.xml >>        * (update) On 2010-12-06 23:58:59 by anonymous #810 : en/contributors.xml >>        * (update) On 2010-12-16 08:56:58 by anonymous #916 : >> en/reference/strings/functions/echo.xml >>        * (update) On 2011-01-08 10:04:57 by anonymous #1091 : en/language-defs.ent >> >> >>    Patches for review : >>    ----------------------- >>        * (update) On 2010-10-15 08:28:58 by conf : en/language/types.xml >>        * (update) On 2010-10-19 04:38:43 by conf : en/language/types/array.xml >>        * (update) On 2010-11-24 14:27:46 by joey : en/reference/pcre/pattern.syntax.xml >> >> >> >> -- >> https://edit.php.net/ >> This email is send automatically by the Php Docbook Online Editor. >> >