Re: Broken build for translations

On Thu, Jul 28, 2011 at 15:30, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: > On Thu, Jul 28, 2011 at 13:40, Alexey Shein <confik@gmail.com> wrote: >> 2011/7/28 Hannes Magnusson <hannes.magnusson@gmail.com>: >>> On Thu, Jul 28, 2011 at 13:14, Alexey Shein <confik@gmail.com> wrote: >>>> There is a bug in configure.php with improper handling >>>> @ENGLISH_ONLY_INCL_BEGIN@ directive, i created the fix (see >>>> attachment). >>>> If it's ok I will commit it. >>> >>> >>> Whopsy. Forgot to provide a default for it :) >>> >>> You need those entities for translations, not english :] >>> >> >> That's why I renamed them in the patch. >> Ok, I will commit. > > I already did fix it by initializing the variable with empty string... > See your commit now.. I don't see how "translation only" makes sense here.. you can't build a translation standalone.. it will comment out those entries when you only build the english translation.. Anyway. Not worth another commit again imo :) -Hannes