Re: Re: svn: /php/php-src/branches/PHP_5_4/ UPGRADING

If we want to remove them in 5.5 (or whatever we end up after 5.4), then it should be documented as deprecated, even if we don't raise E_DEPRECATED for now. On Tue, Nov 22, 2011 at 2:44 PM, Pierrick Charron <pierrick@php.net> wrote: > I personally think that we should do both. As of 5.4 > get_magic_quotes_* are mark them as deprecated to discourage people > using it and will always return false. > > Thanks > Pierrick > > On 22 November 2011 08:29, Peter Cowburn <petercowburn@gmail.com> wrote: > > Hi docs folks, > > > > What are your thoughts on how to treat the > > get_magic_quotes_(gpc|runtime) functions, in the documentation. > > Traditionally we mark functions as deprecated if they're deprecated in > > the code (e.g. PHP_DEP_FE), but that's not the case for these two. > > > > Should we just say in the change log that they'll always return false, > > or should the term "deprecated" be used? > > > > Peter > > > > On 22 November 2011 13:16, Pierre Joye <pierre.php@gmail.com> wrote: > >> they are, we only not raise notices or warnings anymore to keep the > >> user experience at a good level. So please keep them in here :) > >> > >> On Tue, Nov 22, 2011 at 2:11 PM, Pierrick Charron <pierrick@php.net> > wrote: > >>> pierrick Tue, 22 Nov 2011 13:11:20 > +0000 > >>> > >>> Revision: > >>> http://svn.php.net/viewvc?view=revision&revision=319679 > >>> > >>> Log: > >>> Those functions are not deprecated (r319249 #55371) > >>> > >>> Bug: https://bugs.php.net/55371 (Closed) > >>> get_magic_quotes_gpc() > throws deprecation warning > >>> > >>> Changed paths: > >>> U php/php-src/branches/PHP_5_4/UPGRADING > >>> > >>> Modified: php/php-src/branches/PHP_5_4/UPGRADING > >>> =================================================================== > >>> --- php/php-src/branches/PHP_5_4/UPGRADING 2011-11-22 12:47:49 > UTC (rev 319678) > >>> +++ php/php-src/branches/PHP_5_4/UPGRADING 2011-11-22 13:11:20 > UTC (rev 319679) > >>> @@ -258,8 +258,6 @@ > >>> 7. Deprecated > >>> ============= > >>> > >>> -- get_magic_quotes_gpc() > >>> -- get_magic_quotes_runtime() > >>> - mcrypt_generic_end() > >>> - mysql_list_dbs() > >>> > >>> > >>> > >>> -- > >>> PHP CVS Mailing List (http://www.php.net/) > >>> To unsubscribe, visit: > >>> http://www.php.net/unsub.php > >>> > >> > >> > >> > >> -- > >> Pierre > >> > >> @pierrejoye | http://blog.thepimp.net | > >> http://www.libgd.org > >> > >> -- > >> PHP CVS Mailing List (http://www.php.net/) > >> To unsubscribe, visit: http://www.php.net/unsub.php > >> > >> > > > > -- > > PHP CVS Mailing List (http://www.php.net/) > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > > -- Ferenc Kovács @Tyr43l - http://tyrael.hu