Re: working on PhD_PEAR, have questions about PhD / PhD_Generic
| From: | Hannes Magnusson | Date: | Sun, 05 Feb 2012 10:09:42 +0000 |
| Subject: | Re: working on PhD_PEAR, have questions about PhD / PhD_Generic | ||
| References: | 1 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969383615@lists.php.net to get a copy of this message | ||
2012/2/5 Alexey Borzov <borz_off@cs.msu.su>:
> Hi,
>
> I'm currently trying to make HTML generated by PhD_PEAR conform to HTML5
> spec and fix a few more annoying problems with it.
>
> Most of the HTML-generating code, however, lives in PhD or Phd_Generic
> packages. Of course I can override that code in PhD_PEAR, but a cleaner
> solution will be to change it right there. Specifically, I am speaking about
> * Using presentational tags like <b>, <i>, <tt> in Package_Generic_XHTML.
> These can be trivially changed to <strong>, <em>, <code>.
> * Package_Generic_XHTML insists on adding align="left" to all <td> tags not
> having an explicit align attribute and valign="middle" tag to all <tr> tags
> not having an explicit valign attribute, see e.g. source of the doc page
> here [1]. Is there some reasoning behind this or can this be removed?
> * Table-related attributes (where they are actually needed) should be
> converted to CSS styles.
>
> So the question is: can I change the relevant parts in PhD / PhD_Generic? I
> don't see any bad consequences, but I may be missing something.
You need to be very careful when you changed the generated html, even
from <b> to <strong> as there could be lots of CSS specifically
targeting these elements.
In theory it shouldn't be an issue, but its something that needs to be
reviewed before a release at least.
Also, when moving inline presentation elements out to a css can be a
tricky thing, as we don't automatically link to a stylesheet in the
generation.
I think its great that you want to update this, so by all means go for it.
> Also, whom should I contact about pushing a release of PhD_* packages when
> I'm done with this stuff?
Generally me or Moacir.
-Hannes