Re: Done with PhD for now, patch for php.net CSS
| From: | Hannes Magnusson | Date: | Thu, 09 Feb 2012 11:49:27 +0000 |
| Subject: | Re: Done with PhD for now, patch for php.net CSS | ||
| References: | 1 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969383622@lists.php.net to get a copy of this message | ||
2012/2/7 Alexey Borzov <borz_off@cs.msu.su>:
> Hi,
>
> I've done all the changes to PhD packages I intended, documentation
> generated by PhD_PEAR is quite a bit less broken now and almost valid HTML5.
> Please review the changes and let me know if I did break something after
> all. If I didn't, please do the releases.
Kudos. We do new builds few times a day on docs.php.net, I haven't
seen any major issues there.. We can do a release after this Friday I
guess.
> As promised, here is a patch for CSS used on php.net (current version and
> prototype). There were only a few style affected, fortunately.
How about we do a test run on the merge request system?
You fork the repo on github (https://github.com/php/web-php) and file
a merge request, and I'll merge it? :)
Don't believe anyone has tested that yet, this would be a nice test case :)
-Hannes
> On test suite: tests living in tests/php now pass (I've updated the expected
> output), those in tests/xhtml aren't easy to fix as they reference some
> files missing in SVN:
>
> require "include/PhDReader.class.php";
> require "include/PhDFormat.class.php";
> require "formats/xhtml.php";
These tests were written for PhD 0.2 I believe.. ;)
Don't worry about it
-Hannes