Re: Patch submission - curl_unescape, curl_strerror, curl_reset, fix for curl_escape
| From: | Peter Cowburn | Date: | Fri, 14 Jun 2013 08:12:07 +0000 |
| Subject: | Re: Patch submission - curl_unescape, curl_strerror, curl_reset, fix for curl_escape | ||
| References: | 1 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969384402@lists.php.net to get a copy of this message | ||
Hi Adam,
On 12 June 2013 22:11, Adam Kazimierczak <kazymjir@gmail.com> wrote:
> Hello Mailing List,
>
> I am attaching a few new patches. Please let me know what do you think
> about them.
>
There are a few *minor* issues, but overall they are looking good.
curl-reset.xml.patch => typos on line 26 and 41
curl-strerror.xml.patch => See Also, do the (raw)urldecode functions need
to be there? Were they copied from curl_(un)escape?
curl-escape.xml.patch => The function returns false on failure
curl-unescape.xml.patch => Again, this returns false on failure
>
> Cheers,
> Adam
>