Re: edit.php.net and Google account

From: Date: Sun, 05 Oct 2014 15:36:36 +0000
Subject: Re: edit.php.net and Google account
References: 1 2 3 4 5 6 7 8 9  Groups: php.doc 
Request: Send a blank email to phpdoc+get-969385207@lists.php.net to get a copy of this message
Done http://git.php.net/?p=web/doc-editor.git;a=commitdiff;h=032b890be27e529304aca6756f7ce8068997a0ad 2014-10-05 12:46 GMT+02:00 Yannick Torrès <yannick.torres@gmail.com>: > I agree. > > I will test if DisplayName is empty and use google email if it's the case > > I will push a patch for this quickly > > Best, > Yannick > > 2014-10-05 12:38 GMT+02:00 Dmytro X86 <ddev.x86@gmail.com>: > >> It's very strange behavior. >> In Google account settings -> Personal info -> Personal information, I >> have: >> First name : "Dmytro" >> Last name : "X86" >> >> "Name" (used everywhere in Google services, and showed in >> Google account settings -> Personal info -> Personal information) : >> "Dmytro X86" >> >> Now, I found additional (and optional!) field "Nickname" in "Other >> emails" settings. This field was empty. I set this field (same value as >> "Name"), and now google-style login to edit.php.net worked as expected. >> When I enter to edit.php.net, I see "Connected as ["Nickname" value (NOT >> "Name" value!)]". >> >> But I still do not understand, why >> "name":{"familyName":"","givenName":""} >> was empty in Google response. >> >> Also, maybe it's not a good idea to depend on an _optional_ field >> ("Nickname") in Google account settings? >> >> >> >> 05.10.2014 12:09, Yannick Torrès пишет: >> >>> Ok, I just get the raw data send by Google when you authenticate : >>> >>> ================= >>> >>> "kind":"plus#person", >>> >>> "etag":"\"L2Xbn8bDuSErT6QA3PEQiwYKQxM\/4deTgLxH7oCk5aVtij3C7E8VAUU\"", >>> "gender":"male", >>> "emails":[{"value":"ddev.x86@gmail.com >>> >>> <mailto:ddev.x86@gmail.com>","type":"account"}], >>> "objectType":"person", >>> "id":"116183756034134044470", >>> "displayName":"", >>> >>> "name":{"familyName":"","givenName":""}, >>> >>> "image":{"url":"https:\/\/lh3.googleusercontent.com >>> >>> <http://lh3.googleusercontent.com>\/-XdUIqdMkCWA\/ >>> AAAAAAAAAAI\/AAAAAAAAAAA\/4252rscbv5M\/photo.jpg?sz=50", >>> "isDefault":true}, >>> "isPlusUser":false, >>> "circledByCount":0, >>> "verified":false >>> >>> ================= >>> >>> I use the displayName for the editor and you can see that you haven't >>> any. >>> >>> 2 solutions : >>> >>> 1) Edit your google account and fix the displayName for your account >>> 2) If the displayName is empty, I can take the email as login >>> >>> Best, >>> Yannick >>> >>> >>> 2014-10-05 10:08 GMT+02:00 Dmytro X86 <ddev.x86@gmail.com >>> <mailto:ddev.x86@gmail.com>>: >>> >>> Hi, Yannik! >>> >>> I entered now with Google account, result is same. >>> >>> >>> 04.10.2014 23 <tel:04.10.2014%2023>:11, Yannick Torrès пишет: >>> >>> Hi, >>> >>> I just push a commit to log raw information send by Google once >>> the >>> connexion is done. >>> >>> Please, wait a little (sync is needed), then, try again to >>> log-in with >>> your google account and tell me. I will read the log and fix >>> this problem. >>> >>> Best, >>> Yannick >>> >>> 2014-10-03 13:57 GMT+02:00 Dmytro X86 <ddev.x86@gmail.com >>> <mailto:ddev.x86@gmail.com> >>> <mailto:ddev.x86@gmail.com >>> <mailto:ddev.x86@gmail.com>>>: >>> >>> In my case, name in Google account is "Dmytro X86". Only >>> latin >>> characters, digits, and space. >>> >>> 03.10.2014 14 <tel:03.10.2014%2014> <tel:03.10.2014%2014>:27, >>> Yannick Torrès пишет: >>> >>> Hi, >>> >>> I see this behaviors too. >>> I suspect it's an encoding issue >>> >>> I will give it a look as soon as possible. >>> >>> Could you please tell me what's your Google's name ? >>> >>> Best, >>> Yannick >>> >>> 2014-10-03 12:04 GMT+02:00 Rowan Collins >>> <rowan.collins@gmail.com >>> <mailto:rowan.collins@gmail.com> >>> <mailto:rowan.collins@gmail.__com >>> <mailto:rowan.collins@gmail. >>> com>> >>> <mailto:rowan.collins@gmail. >>> <mailto:rowan.collins@gmail.>____com >>> <mailto:rowan.collins@gmail.__com >>> >>> <mailto:rowan.collins@gmail.com>>>>: >>> >>> Dmytro X86 wrote (on 03/10/2014): >>> >>> Hello! >>> >>> When I log in to edit.php.net >>> <http://edit.php.net> >>> <http://edit.php.net> >>> <http://edit.php.net> using >>> theGoogleaccount, I do not see my name from >>> this >>> account. On top >>> of the "Home" tab I see "Connected as [Google >>> icon, NO >>> name], >>> Project: PHP, Language: Ukrainian", same thing >>> on the >>> "Information" block: "[Google icon, NO name] >>> is logged >>> in using >>> the Uk language". >>> >>> >>> I've noticed the same thing. I think it happened >>> when the >>> authentication was rewritten to support more >>> providers >>> (GitHub, etc). >>> >>> >>> >>> >>> >

« previous php.doc (#969385207) next »