Re: taking ownership / rejecting patches in the online editor

Done ! http://git.php.net/?p=web/doc-editor.git;a=commitdiff;h=4006f779427200a5f5975a5a50622ce9eb03d38d Wait for the server sync and test it Best, Yannick 2015-03-30 19:13 GMT+02:00 Yannick Torrès <yannick.torres@gmail.com>: > Seems good for me too ! > > I will take a look how hard it is to do this quickly, > > Best, > Yannick > > 2015-03-30 17:48 GMT+02:00 Hannes Magnusson <hannes.magnusson@gmail.com>: > >> Yannick, I think its ok if we loose the distinction between vcs and admin. >> Anyone with vcs account should be able to do these things. >> >> If a scenario occurs that a vcs user is abusing this then we'll revoke >> his karma and be done with it. >> >> -Hannes >> >> >> On Sun, Mar 29, 2015 at 1:45 PM, Yannick Torrès >> <yannick.torres@gmail.com> wrote: >> > Hi, >> > >> > Yes, you must be defined as an admin for a lang to be able to override a >> > change made by a VCS user >> > >> > Best, >> > Yannick >> > >> > 2015-03-29 20:45 GMT+02:00 Maciek Sokolewicz <tularis@php.net>: >> >> >> >> Hey all, >> >> >> >> I know I'm not very active here anymore; but occasionally I do validate >> >> patches in the online doc editor. For quite a while now I've been >> wondering >> >> why it's impossible for most of us with a VCS account to reject >> patches by >> >> some of the users. >> >> >> >> Right now I noticed it again with the 2 patches by the user 'seros' who >> >> has locked the files and only added whitespace changes. For some >> reason I >> >> can't choose to take ownership of the changes, nor to reject the >> patch... >> >> all I can do is commit it... which obviously I don't want to. >> >> >> >> So... am I just missing something here? Or do we really need to be >> admins >> >> to be able to reject such a patch?? >> >> >> >> - Tul >> >> >> >> --- >> >> This email has been checked for viruses by Avast antivirus software. >> >> http://www.avast.com >> >> >> > >> > >