Re: Re: VCS Account Request: pasindu

Hi Maciek Thanks been waiting long time for that review. bcdiv was outdate by rev 336318. will remember the white spaces next time. +1 On Tue, Apr 7, 2015 at 4:27 AM, Maciek Sokolewicz < maciek.sokolewicz@gmail.com> wrote: > On 7-4-2015 0:25, Pasindu De Silva wrote: > >> Hi Hannes >> What I wanted to do was to go through >> http://news.php.net/php.doc/969385399 and add stuff >> suggested in notes >> to the docs, I have patches on edit but no one has reviewed them, also >> because the edit.php.net <http://edit.php.net> >> preview was down was >> unable to preview my changes, would be great if someone can review them. >> >> sorry for being vague earlier :) >> >> +1 >> >> > Hi Pasindu, > I had a look at your patches; there were only 2 in the review queue. > > One was completely empty, so I rejected it (the bcdiv patch). > > The other patch contained an example (for json_encode, which I will commit > in a moment), and a ton of whitespace changes. The whitespace changes will > need to be removed from the patch; in the future, please try not to add > whitespace changes to your patches. They're rarely useful. > > - Tul > > > > --- > This email has been checked for viruses by Avast antivirus software. > http://www.avast.com > > -- *Pasindu De SilvaLinkedIn <http://www.linkedin.com/in/pasindud>* *ppasindud@gmail.com* <ppasindud@gmail.com> *G+ ppasindud <https://plus.google.com/u/0/107016732778776170349/>*