Re: Re: Moving documentation to git
| From: | Christoph M. Becker | Date: | Sat, 17 Jun 2017 11:26:59 +0000 |
| Subject: | Re: Re: Moving documentation to git | ||
| References: | 1 2 3 4 5 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969386644@lists.php.net to get a copy of this message | ||
Hi Andreas!
On 17.06.2017 at 13:06, Andreas Heigl wrote:
> Am 17.06.17 um 11:14 schrieb Christoph M. Becker:
>
>> On 17.06.2017 at 10:22, Andreas Heigl wrote:
>>
>>> Am 17.06.17 um 08:04 schrieb Maciej Sobaczewski:
>>>
>>>> 3) When migrating from SVN $Revision$ to any solution, do not let
>>>> outdated files on the translations to lost their status. If file a.xml
>>>> in Foo translation is pointing to some other version of the English
>>>> tree, please keep it this information - just in the new format. It
>>>> happened once or twice in the past that such files were just marked
>>>> as EN-Revision: n/a and for many translations it's still a problem
>>>> to these days. Remember it's a difference of updating file a few
>>>> revisions ahead vs retranslating it from scratch. I'm not sure if
>>>> this point is understandable, so let me know if I need to elaborate.
>>>
>>> As I'm using git-svn for the transition that information "should" be
>>> kept as it was before The thing though is that the revision-information
>>> might actually be lost, but the last commit-date of the file is still
>>> available so a connection via the last-commit date makes even more sense
>>> to me.
>>
>> I'm afraid that last-commit date would not be sufficient. Consider
>> somebody commits a quick typo fix (for instance, via a patch submitted
>> to PhDOE) to an otherwise outdated translation; in this case the
>> translation should not claim to be up-to-date. And yes, it would of
>> course be better to update the translation right away, but unfortunately
>> that is often not possible for time reasons.
>
> Thanks for raising your concerns here!
>
> I'm not refering to the last commit-date to the complete repo but to the
> specific file. while
git log -1 --format="%ad" gives
> the latest commit
> date you can also use git log -1 --format="%ad" --
> /path/to/file to
> retrieve the last commit date of that specific file. And I was refering
> to that date that could be used.
>
> Though in your described use-case the last repo change *was* the small
> change and so also on SVN the repo would have the last revision of that
> last file. And when is a change a large one and when is it a small one…
Hmm, just disregard my comment – on further rethinking it turns out that
there is no issue as long as the last commit date is stored in the
English original, and the translations keep having an EN-REVISION tag
which has to be updated manually (or not).
I don't see a real issue with minor fixes in the English originals.
Sorry for the noise!
--
Christoph M. Becker