Re: Re: Merge my patch please

Le 29/05/2018 à 16:17, Christoph M. Becker a écrit :

On 29.05.2018 at 14:24, Jean-Baptiste Nahan wrote:

I have written two patchs for the EN PHP doc.

Thanks for the patches, Jean-Baptiste!

The first, fix the example for the mail() function. The current example cannot work and is disaccording with the description and other example ! http://edit.php.net/?patchID=2919&project=PHP

The new example would only work as of PHP 7.2.0, but the documentation is supposed to cover PHP 5 and PHP 7. The old example is still supposed to work with current PHP versions – the email header injection prevention is supposed to prevent *multiple* *consecutive* \r\n only. Since there is already example #3, it seems to me that we can leave example #5 as is.

Thanks for the explanations. I understand better. I'm going to delete my patch.

The second, is for my extension win32service. For this, I have need to your help for correct my English if is need. http://edit.php.net/?patchID=2884&project=PHP

I have just committed this patch, and will check for typos in due course.

Thanks for apply my patch.