Re: Some questions about contributing
| From: | Girgias | Date: | Sun, 10 Feb 2019 20:10:59 +0000 |
| Subject: | Re: Some questions about contributing | ||
| References: | 1 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969387164@lists.php.net to get a copy of this message | ||
Hey Florian,
I'm a French doc maintainer so I'll try to anwser your questions.
On Sun, 10 Feb 2019 at 20:31, Florian Berberich <
php.florianberberich@outlook.com> wrote:
> Good afternoon team,
>
> I've just started contributing to the docs.
> As not all is completely clear to me, I want to ask some questions:
>
> 1. Search function in the editor:
> Is there any shortcut to jump to the next search result?
>
Not sure I understand what you mean?
> 2. Preview in a popup:
> I get an error every time I try to preview the doc in a popup. Is there
> anything I miss?
> Some special thing I have to do before I click this button?
>
What preview? Not sure either what you mean here.
> 3. How to organize commits into patches:
> Should I create one patch for every file I change? Or is it okay to group
> e.g. translation fixes into one patch?
>
Usually I group them by "Folder"/extension, but for typos I just commit
them all together.
> 4. Parallel update of translation:
> Is it okay to update a translation if I did changes to the english
> version? If yes, should I group them into one patch?
> Or should I wait until the patch was accepted and then do the update?
>
You should probably wait for the English revision to be updated as you need
to reference this revision in the header of
the translated file.
> 5. Commit Patches for review:
> I've seen this "Contributions are ready for review"-mails. Will patches be
> commited for review on their own or
> is there something I have to do?
>
Someone with PHP-DOC karma will need to review them and approve them.
> 6. Subscription address for php.doc.de:
> Somehow I don't get this mailing list stuff. The subscription address for
> this list is phpdoc-subscribe, the one for
> the webmaster list is php-webmaster-subscribe and the one for the
> internals list is internals-subscribe.
> I already tried some combinations but just got error responses or no
> response at all. (Maybe to many requests?)
> Can anybody give me hint?
>
The correct email address should be: doc-de-subscribe@lists.php.net
Best regards
George P. Banyard