Re: Possibility to clean up language snippets

From: Date: Sat, 23 Mar 2019 22:08:10 +0000
Subject: Re: Possibility to clean up language snippets
References: 1 2  Groups: php.doc 
Request: Send a blank email to phpdoc+get-969387193@lists.php.net to get a copy of this message
On Sat, 23 Mar 2019 at 23:00, Peter Cowburn <petercowburn@gmail.com> wrote: > > > On Mon, 18 Mar 2019 at 22:36, G. P. B. <george.banyard@gmail.com> wrote: > >> Hello PHPDoc team >> >> I made a PHP CLI script to extract and count the occurrences of a given >> XML entity in the PHPDoc source. [1] >> > >> It seems that there are a couple which have 0 or only 1 occurrence >> (meaning that it could/should probably be integrated directly). [2] >> >> On a previous run of my script, it retrieved the names of the entities >> with no more than 10 occurrences [3] >> >> Would love to get some opinions on this. >> > > Please be *very* careful to check all languages, active and inactive, so > as not to break the builds. > For one example "&com.use-oo-instead;" still exists in the Chinese > (active) and Persian (inactive) translations. > > We also have an old script in doc-base [1], which should hopefully run > quicker than the 56 minutes (?!) yours says it took. > > >> However, I am currently "hogging" the language-snippet file on the online >> editor with my sprintf (and related functions) patch. >> Also, don't know if I should ask for karma for the English doc >> > > I'll consider that as asking, and have granted you full phpdoc karma > (which includes English and all of the translations). [2] > > >> >> Best regards >> >> George P. Banyard >> >> [1] >> https://gist.github.com/Girgias/dfd0c323cee2d9a8d619b0253f4df694 >> [2] >> https://gist.github.com/Girgias/e823d690866ad1af7165bae2b0e9ccbb >> [3] >> https://gist.github.com/Girgias/8e506dacedcee25234bd2bfc5a3c3664 >> > > [1] > > http://svn.php.net/viewvc/phpdoc/doc-base/trunk/scripts/entities.php?view=markup > [2] > > http://svn.php.net/viewvc/SVNROOT/global_avail?revision=347040&view=revision > > > Hello Peter, If we would go about removing the entities I was think about moving them to the top of the file in a deprecated section as I did last time I looked into the file with a patch approved by @cmb (I can look for the SVN revision if needed) Also I managed to optimise the script a bit more and it's down to 20-25 minutes for EN only. (I forgot to exclude the SVN folder from the grep search). I will have a look at the existing script, thanks for pointing it out. However I'm still working on my script to try to provide an HTML "report" for all the languages. Finally; cheers for providing me with phpdoc karma. Best regards George P. Banyard

« previous php.doc (#969387193) next »