Re: Patch waiting on edit.php.net

On 23.11.2020 at 15:28, BohwaZ wrote: > On Mon, 23 Nov 2020 11:08:36 +0000 / "G. P. B." > <george.banyard@gmail.com> said : > >> The issue is that the Online doc editor is rather unpractical for >> reviewing patches if changes need to be made. >> Added to the fact that we don't usually check it for patches (even >> more now that emails about them aren't sent). >> The best way is to provide a PR to >> https://github.com/php/doc-en > > Sorry but I have no idea how to extract the patch from edit.php.net and > transform it into a PR. > > I just followed the contributing guide, edited the doc online, and it > created a patch, and now it's stuck there :-/ Thanks for the patch! I've tweak it a bit, and applied as <http://svn.php.net/viewvc?view=revision&revision=351547>. It may make sense to actually document the callback function like it's done with SQLite3::createFunction(), for instance, but having the info as is, is already very valuable. [1] <https://www.php.net/manual/en/sqlite3.createfunction.php> Christoph