Re: This PHP Manual build is broken
| From: | Christopher Jones | Date: | Wed, 25 Nov 2020 02:36:06 +0000 |
| Subject: | Re: This PHP Manual build is broken | ||
| References: | 1 2 3 4 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969387662@lists.php.net to get a copy of this message | ||
On 24/11/20 11:31 pm, Christopher Jones wrote:
On 24/11/20 8:43 pm, Yoshinari Takaoka wrote:The OCI-Lob and OCI-Collection classes necessarily got renamed <https://github.com/php/php-src/blob/PHP-8.0/UPGRADING#L401-L403> to OCILob and OCICollection in PHP 8. My intent is just to document the latter names, and have notes that older PHP releases used the old names. E.g like this doc <https://github.com/php/doc-en/commit/0e0c883110b62cc4e5805696a56ff717f7088bfa#diff-721eda1c783c04504a8bad4c13858ec911056cc8bd6d26e10eb7ceb81b516470R66-R74>. Chris -- https://twitter.com/ghrdOn Tue, 24 Nov 2020 09:46:41 +0100 Andreas Heigl <andreas@heigl.org> wrote:Yes it was me; thought it was due to a timing / commit change. My local builds all went fine. I'll check the above commit in my morning tomorrow. CHris That patch broke the OCI8 class names so I need to revert it. I reverted locally and still didn't see any build breakage. Do you know exactly what caused the build system to fail?Hey List! That was not me! ;-) That is a "real" issue!Yes, real issue! I fixed it, maybe. https://urldefense.com/v3/__http://svn.php.net/viewvc?view=revision&revision=351568__;!!GqivPVa7Brio!Pq23PmhyfEGxO5XySTB1Xf31nRhcvyx_s-WuDFYf80T3ubKxh6aEVLpcLXwFq3htVbW-DA$ ---- It seems that this issue was caused by oci8 related id change. https://urldefense.com/v3/__https://github.com/php/doc-en/commit/0e0c883110b62cc4e5805696a56ff717f7088bfa__;!!GqivPVa7Brio!Pq23PmhyfEGxO5XySTB1Xf31nRhcvyx_s-WuDFYf80T3ubKxh6aEVLpcLXwFq3jvLNfu5w$ Best Regards.