Re: Add commit ID to build info
| From: | Adiel Cristo via phpdoc | Date: | Mon, 01 Feb 2021 12:41:09 +0000 |
| Subject: | Re: Add commit ID to build info | ||
| References: | 1 2 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969387827@lists.php.net to get a copy of this message | ||
Thanks, Christoph. PR submitted.
Best regards,
*Adiel Cristo*
Senior PHP Developer
adiel@adielcristo.com
LinkedIn <http://br.linkedin.com/in/adielcristo>
On Mon, Feb 1, 2021 at 9:17 AM Christoph M. Becker <cmbecker69@gmx.de>
wrote:
> On 29.01.2021 at 01:25, Adiel Cristo via phpdoc wrote:
>
> > I fixed the pt_br doc build, but for some reason the changes did not
> > seem to work (or even to be applied) on the remote server.
> >
> > I added some changes on the doc/base/configure.php file to get the
> > commit ID (patch attached), but I'm not sure if I have permissions to,
> > or if I should change this file.
> >
> > Any thoughts?
>
> I'm not sure about the usefulness of this patch, but maybe consider to
> submit that as PR to <https://github.com/php/doc-base>.
>
> Regards,
> Christoph
>
>