Re: bug in 2nd-highest-upvoted mb_check_encoding() comment code
| From: | Sherif Ramadan | Date: | Sat, 14 Aug 2021 07:35:07 +0000 |
| Subject: | Re: bug in 2nd-highest-upvoted mb_check_encoding() comment code | ||
| References: | 1 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969387981@lists.php.net to get a copy of this message | ||
Unfortunately this is the problem with user contributions. They are
subjective by nature as they may offer up buggy implementation or provide
inaccurate information. While this is true they are ranked by popular vote.
So feel free to down vote if you don't like what you see. However editorial
constraints on user contributions are limited unless they violate a serious
problem such as security, spam, or hate speech.
On Fri, Aug 13, 2021, 2:22 PM Hans Henrik Bergan <divinity76@gmail.com>
wrote:
> the comment
>
> https://www.php.net/manual/en/function.mb-check-encoding.php#95289
> is the
> 2nd-highest upvoted comment, and makes some dubious claims, but the code
> provided is bugged and should not be used,
> as a specific example it incorrectly validates "\xC0\x81" , which is
> illegal in UTF8 (quote RFC3629: The octet values C0, C1, F5 to FF never
> appear - ref https://datatracker.ietf.org/doc/html/rfc3629 )
>
> so.. can we at least get an editor's note that the code is bugged,
> incorrectly validates "\xC0\x81", and should not be used?
>