Re: Login is not working. Please help....

From: Date: Sat, 22 Oct 2005 07:57:59 +0000
Subject: Re: Login is not working. Please help....
References: 1 2  Groups: php.general 
Request: Send a blank email to php-general+get-224445@lists.php.net to get a copy of this message
You do know your code is open for sql injection attacks. php.net search for sql injection and session spoofing HTH Andy On Friday 14 October 2005 09:25, Jochem Maas wrote: > try some code indentation to make it more readable. > > someone else pointed you to the 'user' 'name' mismatch already I see. > > twistednetadmin wrote: > ... > > > session_start(); > > switch (@$_GET['action']) // Gets set by the form action > > { > > case "login": > > $sql = "SELECT name FROM DB > > WHERE name='$_POST[user]'"; > > $result = mysql_query($sql) or die("Couldn't execute query."); > > $num = mysql_num_rows($result); > > if ($num ==1) // loginname found > > { > > $sql = "SELECT name FROM DB > > WHERE name='$_POST[user]' > > AND pass=password('$_POST[pass]')"; > > $result2 = mysql_query($sql) or die("Couldn't execute query 2."); > > $num2 = mysql_num_rows($result2); > > if ($num2 > 0) // password is correct > > { > > $_SESSION['auth']="yes"; > > $logname=$_POST['user']; > > $_SESSION['logname'] = $logname; > > header("Location: page1.php"); > > } > > else // password is not correct > > { > > unset($action); > > header("Location: loginerror.php"); > > } > > } > > elseif ($num == 0) // Wrong name. Name not in db > > { > > unset($action); > > header("Location: loginerror.php"); > > } > > > > } > > ... -- Now listening to on amaroK Geek code: www.vlaamse-kern.com/geek Registered Linux User No 379093 If life was for sale, what would be its price? www.vlaamse-kern.com/sas/ for free php utilities --

Attachment: [application/pgp-signature]
« previous php.general (#224445) next »