RE: [PHP] Multiple "if()" statements
| From: | Ford, Mike | Date: | Thu, 29 Jun 2006 08:48:20 +0000 |
| Subject: | RE: [PHP] Multiple "if()" statements | ||
| Groups: | php.general | ||
| Request: | Send a blank email to php-general+get-238898@lists.php.net to get a copy of this message | ||
On 29 June 2006 01:03, David Tulloh wrote:
> I'm also going to throw in an elseif for fun, to get this (hopefully)
> improved version:
>
> if($row[1] == "none") {
> print("<tr>");
> print("<td>$row[0] $row[2]</td>");
> print("</tr>");
> } elseif($row[1] == $row[2]) {
> print("<tr>");
> print("<td>$row[0] $row[2]</td>");
> print("</tr>");
> } else {
> print("<tr>");
> print("<td>$row[0] ($row[1]) $row[2]</td>");
> print("</tr>");
> }
This still seems overly complex to me -- there are 3 identical occurrences of some items.
When constructing an if() sequence, I think it's always important to isolate the parts that
genuinely differ, so my effort would go like this:
echo "<tr>";
echo "<td>$row[0] ";
if ($row[1] != "none" && $row[1] != $row[2]) {
echo "($row[1]) ";
}
echo "$row[2]</td>";
echo "</tr>";
Cheers!
Mike
---------------------------------------------------------------------
Mike Ford, Electronic Information Services Adviser,
Learning Support Services, Learning & Information Services,
JG125, James Graham Building, Leeds Metropolitan University,
Headingley Campus, LEEDS, LS6 3QS, United Kingdom
Email: m.ford@leedsmet.ac.uk
Tel: +44 113 283 2600 extn 4730 Fax: +44 113 283 3211
To view the terms under which this email is distributed, please go to http://disclaimer.leedsmet.ac.uk/email.htm