Re: One last try at this!
| From: | Simon Forster | Date: | Wed, 17 Jan 2007 18:39:42 +0000 |
| Subject: | Re: One last try at this! | ||
| References: | 1 | Groups: | php.general |
| Request: | Send a blank email to php-general+get-247246@lists.php.net to get a copy of this message | ||
On 17 Jan 2007, at 17:38, Beauford wrote:
if(empty($orgname)) { $formerror['orgname'] = "Optional"; } elseif($result = ValidateString($orgname, "2")) { $formerror['orgname'] = $result; } if(empty($website)) { $formerror['website'] = "Optional"; } if($result = ValidateString($website, "2")) { $formerror['website'] = $result; } if(empty($event)) { $formerror['event'] = "Optional"; } if($result = ValidateString($event, "2")) { $formerror['event'] = $result; }Look at your conditional. To my (new to PHP) eyes, you're setting $result to whatever ValidateString($website, "2") returns. It should be: $result == ValidateString($website, "2") Some people countenance conditionals in the form: ValidateString($event, "2") == $result As this usually throws a fairly obvious error if you miss out the extra equals sign. Personally, I don't like this but I can see it helps one write more robust code the first time round. HTH Simon