Re: All-in-one PHP Classes

From: Date: Thu, 08 Feb 2007 00:29:54 +0000
Subject: Re: All-in-one PHP Classes
References: 1 2 3 4 5 6  Groups: php.general 
Request: Send a blank email to php-general+get-248525@lists.php.net to get a copy of this message
# neuhauser@sigpipe.cz / 2007-02-08 01:14:43 +0100: > 290 function setOptions(&$db, $options) > 291 { > 292 if (is_array($options)) { > 293 foreach ($options as $option => $value) { > 294 $test = $db->setOption($option, $value); > 295 if (PEAR::isError($test)) { > 296 return $test; > 297 } > 298 } > 299 } > 300 return MDB2_OK; > 301 } > > The code is careful to not provoke a warning, but returns MDB2_OK if you > screw up and give it a wrong type of value. It's long and has a bug. Actually, that method being a "static" method of MDB2 is a bug in itself. Static methods produce "hard-wired" dependencies. The functionality is useful, but belongs to MDB2_driver_common. -- How many Vietnam vets does it take to screw in a light bulb? You don't know, man. You don't KNOW. Cause you weren't THERE. http://bash.org/?255991

« previous php.general (#248525) next »