Re: file_exists, Windows, and EasyPHP

Edward Vermillion wrote:

On Jun 18, 2007, at 3:30 PM, Myron Turner wrote:

I've written a plugin for DokuWiki which uses the following DokuWiki function for reading files: function io_readFile($file,$clean=true){ $ret = ''; if(@file_exists($file)){ if(substr($file,-3) == '.gz'){ $ret = join('',gzfile($file)); }else if(substr($file,-4) == '.bz2'){ $ret = bzfile($file); }else{ $ret = join('',file($file)); } } if($clean){ return cleanText($ret); }else{ return $ret; } } On Linux machines, this seems to behave as you would hope, that is, if the file doesn't exist then you get back a null string. In any event, none of the users who have installed it on Linux machines have had a problem with it. And I have done several installs myself. But one user installed the plugin on a Windows machine and the code fell through to $ret = join('',file($file)) even though there was no $file. The result was an error message: Permission denied in *E:\Program Files\EasyPHP 2.0b1\www\dokuwiki\inc\io.php* on line *97 *Line 97 is the join. So the function is attempting to read a non-existent file. I was just wondering whether there is some difference in the way his PHP version handles the @ operator in: if(@file_exists($file)) That is, is it possible that by suppressing errors, this expression somehow returns true? And is it a bug?

Are you sure the file doesn't exist? Could it just be that it exists, but the permissions are not set correctly? Ed

I don't really know, since I am depending on the user's feed-back. But apparently he hadn't done anything yet with the plugin, so no files would have been in that directory. But it's a possibility since the code doesn't check for whether the file is readable. It could just be a Windows issue, but I thought I'd check here, because if it's something that others have run into and which I can rectify I'd want to do it. -- _____________________ Myron Turner http://www.room535.org http://www.bstatzero.org http://www.mturner.org/XML_PullParser/