Re: Flexible Shopping Cart (was: Shopping Carts)

From: Date: Thu, 28 Feb 2008 19:23:13 +0000
Subject: Re: Flexible Shopping Cart (was: Shopping Carts)
References: 1 2 3 4 5 6  Groups: php.general 
Request: Send a blank email to php-general+get-270632@lists.php.net to get a copy of this message
Nathan Rixham wrote:
<?$_productCollection=$this->getLoadedProductCollection()?> <?if(!$_productCollection->getSize()):?> <div class="note-msg"> <?=$this->__('There are no products matching the selection.')?> </div> first 5 lines I've seen of it and it's got short-tags, escapes in and out of php/html, no templating engine and no language file, or even concideration of future implementation. and is all that inside a class? I see a $this but no "class classname {" just some constuctive critism, could be good though!
Yeah, I gotta agree here, most of the systems I have worked on have disabled the short-open tags and other things to secure the site, so definitely something to keep in mind. This page alone would break as would <?= tags if they live anywhere (shortcut for "<?php echo "). Wolf

« previous php.general (#270632) next »