Re: Problem in a generate password function

From: Date: Mon, 31 Mar 2008 19:20:37 +0000
Subject: Re: Problem in a generate password function
References: 1  Groups: php.general 
Request: Send a blank email to php-general+get-272349@lists.php.net to get a copy of this message
Mário Gamito wrote:
Hi, I have the code of a function to generate a random 10 character long password following my signature. To test it i do: $clearpass = create_pass(); print('Clear: ' . $clearpass); die(); But the output is only "Clear:" Why isn't it working ? Any help would be appreciated. Warm Regards, Mário Gamito -- function create_pass () { $length=10; $password = ""; $possible = "0123456789abcdefghijklmnopqrstuvxz"; $i = 0; while ($i < $length) {
    $char = substr($possible, mt_rand(0, strlen($possible)-1), 1);
I have a very similar routine, but for the previous line, since you can reference a string as an array, I do this: $char = $possible[mt_rand(0, strlen($possible)-1)]; In this example, it would save ten function calls, if not more. just a suggestion
    if (!strstr($password, $char)) {
      $password .= $char;
      $i++;
    }
} return $password; }
-- Jim Lucas "Some men are born to greatness, some achieve greatness, and some have greatness thrust upon them." Twelfth Night, Act II, Scene V by William Shakespeare

« previous php.general (#272349) next »