Re: how to simplify my code - I will have tooo many lines -pleasehelp
| From: | Shawn McKenzie | Date: | Wed, 21 Jan 2009 18:27:05 +0000 |
| Subject: | Re: how to simplify my code - I will have tooo many lines -pleasehelp | ||
| References: | 1 2 | Groups: | php.general |
| Request: | Send a blank email to php-general+get-286922@lists.php.net to get a copy of this message | ||
Shawn McKenzie wrote:
> Wow! Yes, there are a lot of ways to do it. This is a quick stab (not
> tested):
>
> $Today = date('m/d/y');
>
> if ( $selectedProdCode == "agreem" && $errorArray['agr1expdate']
> < $Today)
> {
> $selectedProdCode= //agreement cost + late fee
> } else {
> $selectedProdCode= //agreement cost
> }
> if ( $selectedProdCode == "agreem2" && $errorArray['agr1expdate']
> >= $Today
> && $errorArray['agr2expdate'] >= $Today )
> {
> $selectedProdCode= //agreement cost * 2
> }
> elseif ( $selectedProdCode == "agreem2" &&
> ($errorArray['agr1expdate'] <
> $Today || $errorArray['agr2expdate'] < $Today) )
> {
> if ( $errorArray['agr1expdate'] < $Today &&
> $errorArray['agr2expdate']
> < $Today )
> {
> $selectedProdCode= //(agreement cost * 2) + (late fee *2)
> } else {
> $selectedProdCode= //(agreement cost * 2) + late fee
> }
> }
>
Here's another stab (not tested). Also, in my previous post I just
copied your code, there should be == instead of = in the if expressions.
$Today = date('m/d/y');
$Agreements = 0;
$lateFees = 0;
if ( $selectedProdCode == "agreem" )
{
$Agreements = 1;
}
elseif ( $selectedProdCode == "agreem2" )
{
$Agreements = 2;
if ( $errorArray['agr2expdate'] < $Today )
{
$lateFees++;
}
}
if ( $errorArray['agr1expdate'] < $Today )
{
$lateFees++;
}
$selectedProdCode= //(agreement cost * $Agreements) + (late fee * $lateFees)
--
Thanks!
-Shawn
http://www.spidean.com