Re: try - catch is not so clear to me...
| From: | Bastien Koert | Date: | Tue, 14 Apr 2009 15:51:16 +0000 |
| Subject: | Re: try - catch is not so clear to me... | ||
| References: | 1 2 3 4 5 6 | Groups: | php.general |
| Request: | Send a blank email to php-general+get-291483@lists.php.net to get a copy of this message | ||
[snip]
>
>
>
> function send_confirmation_email($to, $subject, $body)
> {
> $headers = "MIME-Versin: 1.0\n" .
> "Content-type: text/plain; charset=ISO-8859-1;
> format=flowed\n" .
> "Content-Transfer-Encoding: 8bit\n" .
> "Reply-To: Contact <lamp.lists@yahoo.com>\n".
> "From: Contact <lamp.lists@yahoo.com>\n" .
> "X-Mailer: PHP" . phpversion();
>
> mail($to, $subject, $body, $headers) or die(mysql_errno());
> }
>
> $body is "regular" confirmation text: "Thank you for subscribing. To
> activate your account klick on the following link..." etc.
>
>
>
>
> function send_email_with_error_to_admin($e, $content)
> {
> $error_message = "Caught exception: " . $e->getMessage() . "\n";
> $error_message .= "Code : " . $e->getCode()."\n";
> $error_message .= "File : " . $e->getFile()."\n";
> $error_message .= "Line : " . $e->getLine()."\n";
>
> $to_email = "lamp.lists@yahoo.com";
> $subject = "[Confirmation Error Report] ".$e->getMessage();
> $content .=
>
> "\n--------------------------------------------------------------------------------------------------\n\n";
> $content .= "Error Report:\n\n".$error_message;
> $content .=
>
> "\n--------------------------------------------------------------------------------------------------\n\n";
>
> send_confirmation_email($to_email, $subject, $content);
> }
>
>
>
>
>
Since your function doesn't return anything to the code that calls the
function, your check of
if (!send_confirmation_email($email, $subject, $content))
is always triggering the failure. Try adjusting your function to return the
result of the mail call to see if that handles the checks better
function send_confirmation_email($to, $subject, $body)
{
$headers = "MIME-Versin: 1.0\n" .
"Content-type: text/plain; charset=ISO-8859-1;
format=flowed\n" .
"Content-Transfer-Encoding: 8bit\n" .
"Reply-To: Contact <lamp.lists@yahoo.com>\n".
"From: Contact <lamp.lists@yahoo.com>\n" .
"X-Mailer: PHP" . phpversion();
$result = mail($to, $subject, $body, $headers) or die(mysql_errno());
return $result;
}
--
Bastien
Cat, the other other white meat