Re: elseif statements

On Tue, 2009-05-05 at 11:21 -0400, tedd wrote: > At 10:13 AM -0400 5/5/09, Robert Cummings wrote: > >On Tue, 2009-05-05 at 10:05 -0400, Robert Cummings wrote: > >> On Tue, 2009-05-05 at 09:49 -0400, tedd wrote: > >> > At 2:57 PM -0400 5/4/09, Gary wrote: > >> > >I am trying to get this to work, however it only reads the second if > >> > >statement. I get no error messages, but as I change counties, > >>the % stays > >> > >the same. > >> > > > >> > >Can someone enlighten me, or should I be looking at switch statements? > >> > > > >> > >Thanks for your help. > >> > > > >> > >Gary > >> > > >> > In my opinion, never use elseif -- I've never used it. I don't see > >> > any reason whatsoever to do so. > >> > > >> > In my opinion, whenever your choices exceed two, use switch. > >> > >> That's some of the worst advice I've ever seen. > > > >Just so we all know why... > > Yep -- just so we know why: > > <http://php1.net/a/if-v-switch/> > > It all depends upon how you use the tools at your command. > > My preference is still valid and I think the code is more readable. YMMV. Extra level of indentation, needing to add a break statement for every case. Yours is more verbose and less clear. Forgetting a break statement would lead to a silent bug. Abuse of the switch statement... switching on a constant is not a switch at all. I consider it obfuscated. The techniques you've used are also non-portable to most other languages with a switch construct. Sorry, your attempt to call this good advice fails. Cheers, Rob. -- http://www.interjinn.com Application and Templating Framework for PHP