Re: Mysql statement works in phpmyadmin but not in php page

On Fri, Feb 12, 2010 at 9:31 AM, Jochem Maas <jochem@iamjochem.com> wrote: > Op 2/11/10 10:51 PM, James McLean schreef: >> My personal preference these days is to use Curly braces around >> variables in strings such as this, I always find excessive string >> concatenation such as is often used when building SQL queries hard to >> read, and IIRC there was performance implications to it as well >> (though I don't have access to concrete stats right now). >> >> In your case, the variable would be something like this: >> >> $query="INSERT INTO upload_history (v_id,hour,visits,date) VALUES >> ({$v_id}, {$hour}, {$visits}, '{$date}')"; > > actually IIRC the engine compiles that to OpCodes that equate to: > > $query = 'INSERT INTO upload_history (v_id,hour,visits,date) VALUES ('.$v_id.', > '.$hour.', '.$visits.', '\''.{$date}.'\')'; Interesting point, but the original code is still more readable, the opcode's aren't our problem (at least in this case) :) Cheers