Re: Remove blank lines from a file
| From: | tedd | Date: | Mon, 24 May 2010 16:00:51 +0000 |
| Subject: | Re: Remove blank lines from a file | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.general |
| Request: | Send a blank email to php-general+get-305485@lists.php.net to get a copy of this message | ||
At 2:48 PM -0400 5/23/10, Robert Cummings wrote:
tedd wrote:Rob: Okay, so I didn't correctly identify and understand the problem from the client (the list), but my solution worked for the problem I understood. Whereas:At 1:02 PM -0400 5/22/10, Robert Cummings wrote:Actually, his comment didn't say double line feeds... his comment said I want THIS to look like THAT. And THIS had a triple line feed and THAT completely normalized it to a single line feed. I realize you misunderstood the problem, but where I work, clients don't think a solution based on incorrect presumptions is a valid solution for a clearly defined problem :)tedd wrote:Rob: It's not broken according to my "given", which was "If that is all (i.e., removing double linefeeds), then this will do it:" My code does exactly what was stated.If that is all (i.e., removing double linefeeds), then this will do it: $text_array = array(); $text_array = explode("\n\n", $input_text); $output_text = implode("\n",$text_array);Sorry tedd, this is broken. It doesn't solve problems with runs of greater than 2 newlines which is even in the example :) I would use the following instead which is also line break agnostic with final output in the style for your system: <?php $data = preg_replace( "#[\r\n]+#", PHP_EOL, $input ); ?> Cheers, Rob.
Doh, what's funny is I fixed it in my test script but had already pasted into my email and forgot to update that *lol*. Good catch!You correctly identified and understood the problem, but failed to provide a working solution to the client (the list). It's a good thing that we both have clients who understand we're not prefect. :-) Let's just agree that we both can identify, understand, and solve such minor problems. Cheers, tedd -- ------- http://sperling.com http://ancientstones.com http://earthstones.com