Re: A Review Request
| From: | Joshua Kehn | Date: | Wed, 18 May 2011 19:31:31 +0000 |
| Subject: | Re: A Review Request | ||
| References: | 1 | Groups: | php.general |
| Request: | Send a blank email to php-general+get-312874@lists.php.net to get a copy of this message | ||
On May 18, 2011, at 3:22 PM, tedd wrote:
> Hi gang:
>
> I am considering providing PHP code to the general public via my website
>
> This is my first attempt:
>
> http://sperling.com/php/authorization/
>
> What do you people think?
>
> Cheers,
>
> tedd
>
> --
> -------
> http://sperling.com/
>
I can say I really don't like your bracing style.
I don't see a reason to use a form submit to go back to the login page, instead I normally
present errors on page.
Other then that, looks good. Maybe redirect http://sperling.com/php/ to an index of examples?
Regards,
-Josh
____________________________________
Joshua Kehn | Josh.kehn@gmail.com
http://joshuakehn.com