Re: requesting comments on rajmvServiceLog (access + error logging through PHP and JS to MySQL)

On Tue, May 22, 2012 at 2:32 AM, tamouse mailing lists <tamouse.lists@gmail.com> wrote: > On Mon, May 21, 2012 at 7:31 AM, rene7705 <rene7705@gmail.com> wrote: >> On Mon, May 21, 2012 at 1:17 PM, Simon Schick >> <simonsimcity@googlemail.com> wrote: >>> Specially the function rajmvServiceLog_graphs_raphael_calculateData() with a >>> code of ca. 280 lines is quite long ... >> >> 280 lines is long?! :) > > In general, yes. 280 lines is long. Too long, likely. Usually it > indicates you aren't designing your code in a top-down fashion, and it > is a high candidate for refactoring in order to break out into > reusable functions. A rule of thumb is no more than 50 lines per > function, most much less. Back in the day when we didn't have nifty > gui screens and an 24 line terminals (yay green on black!), if a > function exceeded one printed page, it was deemed too long and marked > for refactoring. Well, I split up that long function into several new functions (using pass-by-reference) this morning.. Problem is, now it won't work anymore due to memory consumption errors! :( I'd love to know what I'm doing wrong here. Demo at http://skatescene.biz/sites/mediabeez.ws/stats Code is attached to this mail.

Attachment: [application/x-httpd-php] rajmvServiceLog-1.0.0.php