[php-src] PR #20746: Fixed bug GH-20745 ("Casting out of range floats to int" applies to strings)
| From: | bwoebi | Date: | Sat, 20 Dec 2025 23:37:38 +0000 |
| Subject: | [php-src] PR #20746: Fixed bug GH-20745 ("Casting out of range floats to int" applies to strings) | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-34331@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/20746
Author: bwoebi
This reverts the warning for float-strings, to whose it never should have been applied in the first
place.
@Girgias We did not vote on that. The PR was done after the RFC, and never up for consideration at
vote time.
Feel free to propose it again for PHP 8.6 - I personally think it only should apply to implicit
casts, in line with https://wiki.php.net/rfc/implicit-float-int-deprecate.
But for PHP 8.5 we should revert this ad-hoc addition to the first PHP 8.5 RC.