[php-src] PR #20790: Fix GH-19961: Static analysis arrayIndexThenCheck warning in firebird
| From: | ndossche | Date: | Sun, 28 Dec 2025 00:15:19 +0000 |
| Subject: | [php-src] PR #20790: Fix GH-19961: Static analysis arrayIndexThenCheck warning in firebird | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-34397@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/20790
Author: ndossche
Static analysis reports that the bounds check comes after reading the byte from the buffer.
In practice, this is tagged data that loops until the end tag is found and therefore there
isn't really a bug. The extra length check is only there for extra hardening.
So we simply silence the static analysers and improve the hardening.
See also https://docwiki.embarcadero.com/InterBase/15/en/Isc_dsql_sql_info()