[php-src] PR #20794: Fix GH-18139: Memory leak when overriding some settings via readline_info()
| From: | ndossche | Date: | Sun, 28 Dec 2025 12:47:50 +0000 |
| Subject: | [php-src] PR #20794: Fix GH-18139: Memory leak when overriding some settings via readline_info() | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-34402@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/20794
Author: ndossche
The reason why freeing was not done yet is because the pointer in these variables may be:
- Static data set by the readline/libedit library initially, not heap data.
- Data set by another thread. Although the libraries appear to be not thread-safe anyway.
To solve this, introduce some TLS variables to hold a pointer for us when we override the settings,
such that we can free them and are certain they are allocated by us.