[php-src] PR #20901: Fix dateformat_format_variant3 test and split into different files
| From: | jordikroon | Date: | Sat, 10 Jan 2026 21:01:21 +0000 |
| Subject: | [php-src] PR #20901: Fix dateformat_format_variant3 test and split into different files | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-34507@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/20901
Author: jordikroon
This test was really long and marked as
XFAIL. There were a few things wrong with the
tests that have been fixed.
Additionally the test is now split up into different files for better maintainability.
Just one note that while testing I stumbled upon the fact that datefmt_format puts a
narrow no-break space (U+202F) between [time] PM. But not necessarily
always. I have added a string replace, because I don't think it matters much for the test
outcome. But it makes it much easier to verify the input/output of the tests.