[php-src] PR #20959: Fix crash in mb_substr with MacJapanese encoding
| From: | alexdowad | Date: | Sat, 17 Jan 2026 13:21:11 +0000 |
| Subject: | [php-src] PR #20959: Fix crash in mb_substr with MacJapanese encoding | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-34589@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/20959
Author: alexdowad
Thanks to the GitHub user @vi3tL0u1s (Viet Hoang Luu) for reporting this issue.
The MacJapanese legacy text encoding has a very unusual property; it is possible for a string to
encode more codepoints than it has bytes. In some corner cases, this resulted in a situation where
the implementation code for mb_substr() would allocate a buffer of size -1. As you can probably
imagine, that doesn't end well.
Fixes GH-20832.
@youkidearitai @ndossche @cmb69