[php-src] PR #21003: Fix getPartsIterator stub
| From: | VincentLanglet | Date: | Thu, 22 Jan 2026 14:32:04 +0000 |
| Subject: | [php-src] PR #21003: Fix getPartsIterator stub | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-34632@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/21003
Author: VincentLanglet
Hi,
I'm not familiar with php codebase but I feel like there is an error in definition of
getPartsIterator
- In the stub the arg is defined as a string
- Looking at the constant it's defined as an int
https://github.com/php/php-src/blob/65b40739221faf4454e923cdbee7f44ee0dae0ba/ext/intl/breakiterator/breakiterator_iterators.stub.php#L9
Also, I dunno if I have to update this code too
https://github.com/php/php-src/blob/65b40739221faf4454e923cdbee7f44ee0dae0ba/ext/intl/breakiterator/breakiterator_arginfo.h#L41
See the inconsistency in the doc
https://www.php.net/manual/en/class.intlpartsiterator.php
https://www.php.net/manual/en/intlbreakiterator.getpartsiterator.php