[php-src] PR #21034: Fix GH-21027: strtotime() incorrectly parses decimal relative values
| From: | khaledalam | Date: | Sun, 25 Jan 2026 12:23:16 +0000 |
| Subject: | [php-src] PR #21034: Fix GH-21027: strtotime() incorrectly parses decimal relative values | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-34662@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/21034
Author: khaledalam
# Description
Fixes #21027
strtotime("2.37685 weeks") returned incorrect result (~414 million seconds
instead of ~1.4 million) because:
- "2.37" matched timeshort24 pattern (hour:minute with dot
separator)
- "685 weeks" was parsed as separate relative offset
## Changes
- Added relnumberdec regex pattern for decimal numbers
- Added relativedec lexer rule to match decimal relative expressions
- Added timelib_get_decimal_nr() helper to parse decimal values
- Added timelib_set_relative_decimal() to convert decimal units to seconds