[php-src] PR #21146: Audit zend_ini_string() and related functions
| From: | Girgias | Date: | Fri, 06 Feb 2026 01:37:47 +0000 |
| Subject: | [php-src] PR #21146: Audit zend_ini_string() and related functions | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-34825@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/21146
Author: Girgias
Conflicts with #21143
I audited the usage of
zend_ini_string() and co as I believe these functions should
return a const char* because they point to a pointer owner by a zend_string
*.
The two other things I am wondering is
- if we should remove the INI_STR() macro as it doesn't follow the usual
convention of "string" being a char* and "str" meaning a
zend_string*.
- if we should remove the INI_ORIG_* macros as they seem mostly pointless?