[php-src] PR #21361: Empty some values of mysqli_get_charset()
| From: | kamil-tekiela | Date: | Fri, 06 Mar 2026 17:58:20 +0000 |
| Subject: | [php-src] PR #21361: Empty some values of mysqli_get_charset() | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-35110@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/21361
Author: kamil-tekiela
state and dir were already constants. comment was
undocumented and probably exposed unintentionally, as it doesn't report anything useful.
number is emptied because this value probably should not be exposed to the users. It
can be misleading. The value represents the ID that PHP associates with that character set based on
the IDs of the default collations on the server (which can change so it can never be relied upon).
Before anyone asks about BC: this function never promised that the values wouldn't change. In
the past, it has changed depending on which driver was used. I doubt anyone uses this useless
function, but to keep the BC to minimum, the structure remains as documented in the PHP manual.
Using the old values could even be considered a programming error as they haven't got a meaning
outside of mysqlnd internals.