[php-src] PR #21385: [FrankenPHP] Make php-cli functionality available in embed build
| From: | henderkes | Date: | Sun, 08 Mar 2026 03:45:02 +0000 |
| Subject: | [php-src] PR #21385: [FrankenPHP] Make php-cli functionality available in embed build | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-35134@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/21385
Author: henderkes
see https://github.com/php/php-src/pull/21354
This is a slightly different approach where instead of guarding main method with a define, it's
moved to a different php_cli_main.c file. Means we don't need the Makefile fragment anymore.
Also keeps the do_php_cli symbol in the cli headers here.
So far, I prefer this option over the others because it introduces the least changes and
doesn't duplicate any feature checks or sources. The drawback is of course that building
embed would require cli, but every approach taken will necessitate
building the cli sources anyhow.