[php-src] PR #21386: ext/pgsql: Fix preprocessor guard typos that silently disabled features
| From: | KentarouTakeda | Date: | Sun, 08 Mar 2026 11:55:35 +0000 |
| Subject: | [php-src] PR #21386: ext/pgsql: Fix preprocessor guard typos that silently disabled features | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-35136@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/21386
Author: KentarouTakeda
1. Remove dead
VE_PG_LO64 guards from
pg_lo_tell()/pg_lo_truncate().
GH-14628 removed HAVE_PG_LO64 from the build system and the corresponding guard in
pg_lo_seek(), but missed these two functions. The leftover guards reference undefined
VE_PG_LO64 (a misspelling of the removed HAVE_PG_LO64), making the
lo_tell64()/lo_truncate64() code paths permanently dead.
2. Fix PQTRACE_SUPPRESS_TIMESTAMPS guard misspelling in pgsql.stub.php.
The guard has been misspelled as PQTRACE_SUPPPRESS_TIMESTAMPS (three P's) since
7ec8ae12c4b, preventing the PGSQL_TRACE_SUPPRESS_TIMESTAMPS constant from being
registered.