[php-src] PR #21563: allow clang to build tailcall vm on windows, use __preserve_none for Call VM if available
| From: | henderkes | Date: | Sat, 28 Mar 2026 13:57:33 +0000 |
| Subject: | [php-src] PR #21563: allow clang to build tailcall vm on windows, use __preserve_none for Call VM if available | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-35416@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/21563
Author: henderkes
Not the largest improvement (~5-8% in my testing), but msvc's __preserve_none is not stable
enough to use the tailcall vm with
[[msvc::musttail]].
The tailcall VM for clang is a nice 25-30% improvement, but it still lags far behind msvc.
I'm not 100% sure if switching the call vm to __preserve_none could have any ill effects, but
tests passed on 8.5.4 branch. After rebasing to master they fail locally, but the failures seem
unrelated to these changes.
PS: removing /GUARD:CF (from PHP_SECURITY_FLAGS) gives a 40% performance
uplift in phoronix phpbench. I'm guessing disabling that isn't a good idea?