[php-src] PR #21665: Fix flaky timezone test fixture (GH-18624)
| From: | hakre | Date: | Tue, 07 Apr 2026 19:05:49 +0000 |
| Subject: | [php-src] PR #21665: Fix flaky timezone test fixture (GH-18624) | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-35609@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/21665
Author: hakre
As documented in [RunningTests], tests have to be written to be independent of any php.ini file.
Without specifying the timezone, the var_dump() will make use of the default timezone that may not
be the expected "UTC" timezone.
This renders the test-cases flaky and will make them fail if the
date.timezone is
different from the string "UTC".
Fix is to interpolate the timezone in the test fixture or to set date.timezone to
UTC.
[RunningTests]: docs/source/miscellaneous/running-tests.rst
fix-up-of: GH-18624